Skip to content

[Migrate] mui-datatables from JavaScript to TypeScript#57

Open
Rajesh-Nagarajan-11 wants to merge 1 commit intolayer5io:masterfrom
Rajesh-Nagarajan-11:Migration-TS
Open

[Migrate] mui-datatables from JavaScript to TypeScript#57
Rajesh-Nagarajan-11 wants to merge 1 commit intolayer5io:masterfrom
Rajesh-Nagarajan-11:Migration-TS

Conversation

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 commented May 8, 2026

Notes for Reviewers

This PR fixes #50

Changes :

  • Converted .js / .jsx files to .ts / .tsx inside src/
  • Introduced and configured tsconfig.json
  • Added strong typings across core components and utilities
  • Updated scripts and TypeScript support in package.json

Testing and Build Verification :

1. mui-datatables Tests :

  • Ran all existing Mocha tests in mui-datatables
  • Verdict: ✅ Total: 234 tests passing in ~10 seconds

2. Example Site Verification:

  • Ran the example site
  • Verdict:
    • ✅ Example site rendered successfully
    • ✅ All tables rendered correctly
    • ✅ Sorting, filtering, pagination, and other functionalities are working as expected

3. Build Verification :

  • Built mui-datatables after the migration
  • Verdict:
    • ✅ Build completed successfully
    • ✅ dist/ generated successfully in 4.6s

4. Compatibility Verification:

  • Sistent :

    • Installed migrated mui-datatables with Sistent and verified the build
    • Verdict:
      • ✅ Successfully installed
      • ✅ Build succeeded
  • Meshery UI :

    • Installed migrated mui-datatables with Meshery UI along with Sistent
    • Verdict:
      • ✅ Successfully installed
      • ✅Build succeeded
      • ✅ Tables rendered as expected
      • ✅ GitHub workflow for testing mui-datatables with Meshery UI also succeeded

Next Steps :

  • Currently, only the src codebase has been migrated to .ts / .tsx
  • Next step is migrating test files to TypeScript
  • Example site can also be migrated to .ts / .tsx if needed

Attached demo video showcasing the example site functionality and verification after the TypeScript migration

Screencast.from.2026-05-09.14-28-21.webm

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
Comment thread package.json
"check-coverage": true,
"all": true,
"include": [
"src/**/*.js"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"src/**/*.js" should be "src/**/*.ts", "src/**/*.tsx"

Comment thread package.json
"src/**/*.js"
],
"exclude": [
"test/**/*.test.js"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here "test/**/*.test.ts", "test/**/*.test.tsx"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test files are't migrated in this PR , it's only migrated Src/

columns: MUIDataTableColumnState[];
}

interface UseColumnDropOptions {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t we directly import from src/types/drag.ts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate mui-datatables from JavaScript to TypeScript

2 participants